perf: py_venv.bzl optimizations #725
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbarsky
commented
Nov 23, 2025
| site_packages_pth_file, | ||
| env_file, | ||
| venv_tool, | ||
| ] + py_toolchain.files.to_list()), |
Collaborator
Author
There was a problem hiding this comment.
py_toolchain should already be in rfs
|
dzbarsky
force-pushed
the
zbarsky/optimize
branch
from
9f5d7d1 to
1c9b48c
Compare
arrdem
reviewed
Dec 4, 2025
| @@ -1,5 +1,5 @@ | |||
| # tools_telemetry | |||
| bazel_dep(name = "aspect_tools_telemetry", version = "0.2.8") | |||
| bazel_dep(name = "aspect_tools_telemetry", version = "0.3.2") | |||
arrdem
reviewed
Dec 4, 2025
Comment on lines
+111
to
+153
| workspace_name = ctx.workspace_name | ||
|
|
||
| args = ctx.actions.args() | ||
| args.add_all([venv_dir], expand_directories = False, format_each = "--location=%s") | ||
| args.add(py_shim.bin.bin, format = "--venv-shim=%s") | ||
|
|
||
| # Post-bzlmod we need to record the current repository in case the | ||
| # user tries to consume a `py_venv_binary` across repo boundaries | ||
| # which could cause repo mapping to become relevant. | ||
| args.add( | ||
| ctx.label.repo_name or workspace_name, | ||
| format = "--repo=%s", | ||
| ) | ||
| args.add_all( | ||
| [py_toolchain], | ||
| map_each = lambda py_toolchain: _interpreter_path(workspace_name, py_toolchain), | ||
| format_each = "--python=%s", | ||
| allow_closure = True, | ||
| ) | ||
| args.add(site_packages_pth_file, format = "--pth-file=%s") | ||
| args.add(env_file, format = "--env-file=%s") | ||
| args.add_all([ctx.bin_dir], expand_directories = False, format_each = "--bin-dir=%s") | ||
| args.add(ctx.attr.package_collisions, format = "--collision-strategy=%s") | ||
| args.add(venv_name, format = "--venv-name=%s") | ||
| args.add(ctx.attr.mode, format = "--mode=%s") | ||
| args.add( | ||
| "{}.{}".format( | ||
| py_toolchain.interpreter_version_info.major, | ||
| py_toolchain.interpreter_version_info.minor, | ||
| ), | ||
| format = "--version=%s", | ||
| ) | ||
| args.add( | ||
| "true" if ctx.attr.include_system_site_packages else "false", | ||
| format = "--include-system-site-packages=%s", | ||
| ) | ||
| args.add( | ||
| "true" if ctx.attr.include_system_site_packages else "false", | ||
| format = "--include-user-site-packages=%s", | ||
| ) | ||
|
|
||
| if ctx.attr.debug: | ||
| args.add("--debug") |
Collaborator
There was a problem hiding this comment.
This seems worthwhile if we can peel it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.pathusage so we can enable path-mapping and dedupe the action across configsChanges are visible to end-users: no
Test plan